adding rpi support for prometheus + some supplementals #383
Conversation
There was a problem hiding this comment.
In 'tools/rpi/optional-requirements.txt' you write "prometheus_client", is here no version available?
I cant test it now, but it shows clear for me.
No abnormalities discovered.
I haven't tested it, may have to wait a bit until someone can verify that. But at first glance it looks to me like a clean extension with Prometheus for Grafana.
|
I didnt put version, because I tested it with at least 2 different versions. I dont rely on any special stuff in that prometheus-client library, just core functionality, so I would let pip decide which version suits best to all the other requirements. Thats why I didnt put any specific version. Not like with CUDA and/or tensorflow stuff and such .. ;) |
|
Except for the time-to-sleep you factored out in tools/rpi/main.py it looks quite readable to me. |
Thats right, might be a relict from testing. Left by mistake. I will try to put it again. |
While doesnt seem to be required when looking at it closely .. Just removed variable and put the code from it directly where the variable was used. Please dont ask me why I did .. Dont remember anymore |
Ok, but this way you re-introduced a bug that could lead to negative sleep time and thus a crash of the application ;-) So before creating a merge request, it is highly advisable to merge the - most likely updated - main branch into your feature branch to make sure you didn't miss anything. |
|
Anything I should do now ? Just clarifying responsibilities .. expecting anything from me ? |
|
does anybody maintain this feature? |
|
I am not sure, from my side.... no. |
|
I'll take a look in the next days.
Best regards
DanielR92 ***@***.***> schrieb am Mo., 27. März 2023, 15:55:
… I am not sure, from my side.... no.
—
Reply to this email directly, view it on GitHub
<#383 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCPZPNVAE347ZYRV67OIFLW6GS7DANCNFSM6AAAAAARWCDXWY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I tried to merge latest stuff into my own fork, but at least on my RPI4 ist not running after merging everything .. so I cannot verify its running with this latest stuff .. What to do ? |
|
feature looks nice. I'm looking forward to that!! |
|
Guys, wanted to come back to this after a while now. Anything I can do or are you still wating for me to do anything ? |
Decided I want prometheus support in RPi thing.
Added docker-compose to run whole prometheus stack on that rpi. For me its sufficient to have stats when I am at home.
Added systemd file to run the hoymiles thing as a service on rpi.